fix: consider the cli install directory when resolving plugins #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 12d1742 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Test suite run success833 tests passing in 120 suites. Report generated by 🧪jest coverage report action from 12d1742 |
tatomyr
approved these changes
Jan 7, 2025
JLekawa
reviewed
Jan 7, 2025
Co-authored-by: Jacek Łękawa <[email protected]>
JLekawa
approved these changes
Jan 7, 2025
volodymyr-rutskyi
deleted the
fix/use-cli-install-dir-for-plugins-resolving
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
There is an issue when running the
npx @redocly/cli previewcommand when the@redocly/realmpackage is not installed in the project'snode_modules: it's dependent package cannot be resolved.This happens because the npx installs both the
@redocly/realmand it's dependency@redocly/openapi-coreinto a cache directory (~/.npm/_npxfor mac and linux) but when resolving plugins, only the project directory is considered.This PR adds the package location to the list of directories to resolve the Realm plugins from.
Reference
Testing
Screenshots (optional)
Check yourself
Security